Skip to content

Add gevent / boto3 threads warning#164

Open
scottgigante wants to merge 2 commits intoetianen:masterfrom
scottgigante:patch-2
Open

Add gevent / boto3 threads warning#164
scottgigante wants to merge 2 commits intoetianen:masterfrom
scottgigante:patch-2

Conversation

@scottgigante
Copy link
Copy Markdown
Contributor

Closes #162

@etianen
Copy link
Copy Markdown
Owner

etianen commented Sep 8, 2024

Thanks for the PR!

This warning feels a bit unspecific, like it will trigger false warnings.

How about also checking greenlet.getcurrent()?

@scottgigante
Copy link
Copy Markdown
Contributor Author

@etianen is this what you had in mind? I'm not certain that it's right -- this checks whether or not we are running in the main thread, but I suspect the issue is the existence of gevent's monkey-patched sockets module, which will exist as soon as gevent has been imported (hence the check of sys.modules).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frequent time-outs / failures in storage.save used with gevent

2 participants