Open
Conversation
ffurrer
approved these changes
May 7, 2020
Contributor
ffurrer
left a comment
ffurrer
left a comment
There was a problem hiding this comment.
Sorry, did this review apparently a long time ago but never submitted it.
LGTM maybe double check, that the default behaviour is the same as before.
| "The threshold of what is still convex.", 0.97, 0.0, 1.0) | ||
| min_convexity.add( | ||
| "min_convexity_projection_threshold", double_t, 0, | ||
| "The threshold for dot product between normal and projection plane normal. If the value is close to 1.0 it means that the projected normal is less reliable and should be discarded.", |
|
|
||
| // Constant cv::Mats. | ||
| cv::Mat zeros = cv::Mat::zeros(depth_map.size(), CV_32FC1); | ||
| cv::Mat ones = cv::Mat::ones(depth_map.size(), CV_32FC1); |
Contributor
There was a problem hiding this comment.
also make them const, if you write it in the comment :)
if we need them in any other method, we could also construct them in the constructor, but probably fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a direction aware convexity measure.
The normals are projected onto planes defined by the kernel points and z direction, afterwards convexity measure is calculated from these.
Also adds two new unit tests without the ground truth data.