Skip to content

ENG-2807: Gate all Entra UI content behind entraMonitor feature flag#7744

Draft
dsill-ethyca wants to merge 3 commits intomainfrom
ENG-2807-gate-entra-monitor-flag
Draft

ENG-2807: Gate all Entra UI content behind entraMonitor feature flag#7744
dsill-ethyca wants to merge 3 commits intomainfrom
ENG-2807-gate-entra-monitor-flag

Conversation

@dsill-ethyca
Copy link
Contributor

@dsill-ethyca dsill-ethyca commented Mar 24, 2026

Ticket ENG-2807

Description Of Changes

Gate all Entra-related UI content behind the entraMonitor feature flag. Previously, the flag only controlled whether Entra appeared in the "Add Integration" modal. If an Entra integration already existed in the database, it would still show up in the integration list, be accessible via direct URL, and appear in the action center monitor list.

Code Changes

  • Filter ConnectionType.ENTRA from the integration list API query when entraMonitor is disabled (pages/integrations/index.tsx)
  • Redirect to integration list when navigating to an Entra integration detail page with the flag off (pages/integrations/[id].tsx)
  • Filter Entra monitors from action center results client-side, preserving Okta and other infrastructure monitors (MonitorList.tsx)

Steps to Confirm

  1. Set entraMonitor to false in flags.json
  2. Confirm Entra integrations do not appear in the integrations list table
  3. Confirm navigating directly to /integrations/<entra-key> redirects to the integration list
  4. Confirm Entra monitors do not appear in the action center monitor list
  5. Confirm Okta monitors still appear normally in the action center
  6. Set entraMonitor to true and confirm all Entra content is visible

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

dsill-ethyca and others added 3 commits March 23, 2026 14:46
The entraMonitor flag was only checked in the Add Integration modal.
Existing Entra integrations leaked through to the integration list,
detail page, and action center. This adds flag checks to:

- Integration list: filter ENTRA from the connection types query
- Integration detail: redirect to list if Entra + flag off
- Action center MonitorList: filter Entra monitors from results

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Contributor

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Mar 24, 2026 3:54pm
fides-privacy-center Ignored Ignored Mar 24, 2026 3:54pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant