ENG-2807: Gate all Entra UI content behind entraMonitor feature flag#7744
Draft
dsill-ethyca wants to merge 3 commits intomainfrom
Draft
ENG-2807: Gate all Entra UI content behind entraMonitor feature flag#7744dsill-ethyca wants to merge 3 commits intomainfrom
dsill-ethyca wants to merge 3 commits intomainfrom
Conversation
The entraMonitor flag was only checked in the Add Integration modal. Existing Entra integrations leaked through to the integration list, detail page, and action center. This adds flag checks to: - Integration list: filter ENTRA from the connection types query - Integration detail: redirect to list if Entra + flag off - Action center MonitorList: filter Entra monitors from results Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2807
Description Of Changes
Gate all Entra-related UI content behind the
entraMonitorfeature flag. Previously, the flag only controlled whether Entra appeared in the "Add Integration" modal. If an Entra integration already existed in the database, it would still show up in the integration list, be accessible via direct URL, and appear in the action center monitor list.Code Changes
ConnectionType.ENTRAfrom the integration list API query whenentraMonitoris disabled (pages/integrations/index.tsx)pages/integrations/[id].tsx)MonitorList.tsx)Steps to Confirm
entraMonitortofalseinflags.json/integrations/<entra-key>redirects to the integration listentraMonitortotrueand confirm all Entra content is visiblePre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works