Draft
Conversation
Updating test for endpoints
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Vagoasdf
force-pushed
the
ENG-567_pr2-saas-config-version
branch
from
bf2caf2 to
b3ebb01
Compare
- Use conditional logger.info calls instead of mixing f-strings with loguru placeholders in log_start/log_retry - Add comment explaining _saas_version is snapshotted at construction time - Fix missing blank line between test functions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This will save a snapshot of the connection config history th check during runtime
- Remove duplicate SaaSConfigVersion import in saas_config_endpoints.py - Register ConnectionConfigSaaSHistory in db/base.py for SQLAlchemy metadata - Replace bare db.add/commit/refresh with existing.save(db) in SaaSConfigVersion.upsert - Move `import yaml` from function bodies to module top in connector_template_endpoints.py - Extract _get_version_row helper to eliminate duplicated query in config/dataset endpoints - Clarify datasets falsy check: `datasets if datasets else None`
Vagoasdf
force-pushed
the
ENG-567_pr2-saas-config-version
branch
from
b3ebb01 to
0d2296b
Compare
Base automatically changed from
ENG-567_record-integration-version-on-exec-logs
to
main
March 24, 2026 13:10
- Fix unsorted imports (ruff I001) in base.py, seed.py, and connector_template_endpoints.py - Fix mypy return type error in list_connector_template_versions — convert ORM rows to SaaSConfigVersionResponse explicitly - Annotate saas_config_version and connection_config_saas_history tables in db_dataset.yml to fix fides_db_scan - Add changelog entry for PR #7688 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket []
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works