Skip to content

feat(server): Remove dupe block check #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samcm wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(server): Remove dupe block check #445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e3a163
refactor: remove non-finalized block caching logic from Filter method
samcm Mar 4, 2025
54ecc86
refactor(beacon_block_v2.go): remove unused time import
samcm Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions pkg/server/service/event-ingester/event/beacon/eth/v2/beacon_block_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"errors"
"fmt"
"time"

"github.com/attestantio/go-eth2-client/spec"
v2 "github.com/ethpandaops/xatu/pkg/proto/eth/v2"
Expand Down Expand Up @@ -97,21 +96,6 @@ func (b *BeaconBlockV2) Filter(ctx context.Context) bool {
return true
}

// check if block wasn't finalized when requested and filter if already in cache
if !additionalData.EthV2BeaconBlockV2.GetFinalizedWhenRequested() {
key := "beacon_block" + ":" + hash

_, retrieved, err := b.nonFinalizedCache.GetOrSet(ctx, key, version, time.Minute*30)
if err != nil {
b.log.WithError(err).Error("failed to retrieve from cache")

return true
}

// If the block is already in the cache, filter it out
return retrieved
}

return false
}

Expand Down
Loading