Conversation
…zation Break down the 1390-line monolithic component into 11 focused modules with clear separation of concerns. New architecture: - SlotProgressTimeline.tsx (319 lines): Main component & state orchestration - useTraceSpans.ts (919 lines): All span-building logic extracted into custom hook - TimelineHeader, TimelineGrid, TimelineLegend: Reusable UI components - TimelineTooltip, TimelineRow: Extracted sub-components for future optimization - constants.ts, utils.ts, types.ts: Shared utilities and type definitions Features: - Exclude outliers toggle (default: ON) for cleaner parent span calculations - Point-in-time display: individual node observations now show absolute time instead of fake durations - Contributor filtering with URL parameter persistence - Outlier detection via IQR-based statistical analysis - Classification-based node coloring (internal=teal, individual=violet) Add Timeline tab to slot detail page with integrated contributor filter that persists to URL. Always fetch blob and data column data (handles Fulu fork edge cases).
samcm
changed the title
mattevans
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
Timelinetab to the slot breakdown, OLTP/Jaeger style.