Skip to content

Removed 14 unnecessary stubbings in AutoLoginFilterTest.java#4

Open
Mbd06b wants to merge 1 commit intoethosengine:2.1.1from
ARUS2023:remove-unnecessary-stubbings-3
Open

Removed 14 unnecessary stubbings in AutoLoginFilterTest.java#4
Mbd06b wants to merge 1 commit intoethosengine:2.1.1from
ARUS2023:remove-unnecessary-stubbings-3

Conversation

@Mbd06b
Copy link
Member

@Mbd06b Mbd06b commented Feb 1, 2025

ARUS2023 commented on Oct 5, 2023

In our analysis of the project, we observed that

  1. 6 unnecessary stubbings are created but never executed by the test: AutoLoginFilterTest.testFilter;
  2. 3 unnecessary stubbings are created but never executed by the test: AutoLoginFilterTest. testFilterDisbled ;
  3. 5 unnecessary stubbings are created but never executed by the test: AutoLoginFilterTest.testFilterTemporarilyDisbled;

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

@Mbd06b Mbd06b changed the base branch from 2.1.x to 2.1.1 February 1, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants