Open
Conversation
…f max Changes the skipped rounds price adjustment to use changeRate[1] (as if 1 player participated) instead of changeRate[0] (maximum penalty for no players). Impact: - 10 skipped rounds: +60.0% instead of +61.8% price increase - More predictable and less aggressive price spiraling - Still incentivizes participation but less punishing during network issues This implements the 'defanged' approach suggested in code comments.
Adds comprehensive test to verify that skipped rounds now use changeRate[1] (1 player rate) instead of changeRate[0] (maximum penalty). Test demonstrates: - With 3 skipped rounds, difference is ~0.06% (15 price units) - New approach is less aggressive but still incentivizes participation - Verifies contract behavior matches expected calculation
Updates test expectations to use increaseRate[1] instead of increaseRate[0] for skipped rounds calculations, matching the defanged approach. All 159 tests now pass with the new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the skipped rounds price adjustment to use changeRate[1] (as if 1 player participated) instead of changeRate[0] (maximum penalty for no players).