fix(transaction): improve gas estimation reliability and error handling#5344
Open
gacevicljubisa wants to merge 3 commits intomasterfrom
Open
fix(transaction): improve gas estimation reliability and error handling#5344gacevicljubisa wants to merge 3 commits intomasterfrom
gacevicljubisa wants to merge 3 commits intomasterfrom
Conversation
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This fixes "intrinsic gas too low" errors when MinEstimatedGasLimit was 0
and estimation failed. The fallback ensures transactions can proceed even
when RPC balance checks fail, since actual transaction cost is typically
much lower than maximum theoretical cost used in estimation.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):