refactor(libp2p): use precise connection cleanup in handshake error handling#5330
Open
gacevicljubisa wants to merge 1 commit intomasterfrom
Open
refactor(libp2p): use precise connection cleanup in handshake error handling#5330gacevicljubisa wants to merge 1 commit intomasterfrom
gacevicljubisa wants to merge 1 commit intomasterfrom
Conversation
janos
approved these changes
Jan 24, 2026
martinconic
approved these changes
Jan 26, 2026
akrem-chabchoub
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
refactor(libp2p): use precise connection cleanup in handshake error handling
Replace ClosePeer() with Conn().Close() for connection-specific errors
during handshake. ClosePeer() terminates all connections to a peer,
while Conn().Close() only closes the specific failed connection.
This prevents disrupting healthy concurrent connections and improves
handling of duplicate connection attempts by preserving existing
sessions when rejecting new redundant connections.
Changes:
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):