fix(p2p): give each underlay address fresh 15s connection timeout#5328
Merged
gacevicljubisa merged 3 commits intomasterfrom Feb 13, 2026
Merged
fix(p2p): give each underlay address fresh 15s connection timeout#5328gacevicljubisa merged 3 commits intomasterfrom
gacevicljubisa merged 3 commits intomasterfrom
Conversation
martinconic
approved these changes
Jan 26, 2026
akrem-chabchoub
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Previously, when connecting to a peer with multiple underlay addresses, all addresses shared a single timeout context. This meant later addresses had little to no time remaining for connection attempts. Now each address receives its own fresh 15-second timeout, ensuring fair connection attempts to all underlay addresses.
In kademlia's bootnode connection logic, the global 15-second timeout has been removed and replaced with a per-connection 45-second timeout, allowing multiple addresses per peer to be tried sequentially with adequate time budget.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):