fix: safe reserve capacity doubling with runtime monitor on insufficient stake#5315
Open
martinconic wants to merge 2 commits intomasterfrom
Open
fix: safe reserve capacity doubling with runtime monitor on insufficient stake#5315martinconic wants to merge 2 commits intomasterfrom
martinconic wants to merge 2 commits intomasterfrom
Conversation
Member
|
Instead of polling every 10 minutes, we should trigger UpdateHeight directly from stakingDepositHandler after a successful DepositStake. Staking can only happen via the API The only case polling would cover is if someone stakes directly on the smart contract bypassing the bee API, but that's not a supported workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
ReserveCapacityDoubling, it now logs a warning and skips the on-chainUpdateHeighttransaction. The node starts with the increased local capacity but without redistribution rewards.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):