fix: Twitter + GitHub login integration [$15]#17
Open
jeffmarcilliat wants to merge 1 commit intoethereumbuilders:masterfrom
Open
fix: Twitter + GitHub login integration [$15]#17jeffmarcilliat wants to merge 1 commit intoethereumbuilders:masterfrom
jeffmarcilliat wants to merge 1 commit intoethereumbuilders:masterfrom
Conversation
Implements solution for #N/A Changes: - i18n/en.i18n.json - settings.example.json - client/views/errors/no_account.html - README.md - lib/users.js - meteor/packages - packages/cb-theme/lib/client/stylesheets/screen.scss - Accounts.onCreateUser - client/views/errors/no_account.js - server/users.js - lib/config/at_config.js - client/views/users/social_login.js - client/views/users/social_login.html - server/oauth_config.js Generated by Freelance Agent using Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the solution for #this bounty.
Changes
h service configuration for useraccounts:
socialLoginStyle: 'popup'optionAccountsTemplates.addService('twitter')andAccountsTemplates.addService('github')server/users.js- UpdatedAccounts.onCreateUserto handle OAuth user creation:screenNameor GitHubusernamelib/users.js- Updated user helper functions:getUserName()getGitHubName()to use correct field (usernameinstead ofscreenName)getGitHubNameById()helper functionclient/views/errors/no_account.html- Updated to include both Twitter and GitHub login buttonsclient/views/errors/no_account.js- Added GitHub login event handler alongside existing Twitter handlerpackages/cb-theme/lib/client/stylesheets/screen.scss- Added CSS styling for social login buttonsi18n/en.i18n.json- Added i18n translation strings for social login UIREADME.md- Added documentation for OAuth configurationFiles Created:
server/oauth_config.js- Server-side OAuth service configuration that reads credentials fromMeteor.settingsor environment variablesclient/views/users/social_login.html- Reusable social login buttons templateclient/views/users/social_login.js- Client-side JavaScript for social login button functionalitysettings.example.json- Example settings file showing how to configure OAuth credentialsHow to Enable Social Login:
settings.example.jsontosettings.jsonand add your credentialsmeteor --settings settings.jsonThe social login buttons will appear on the login page and the "no account" page, allowing users to register and sign in with their Twitter or GitHub accounts.
Files Modified
i18n/en.i18n.jsonsettings.example.jsonclient/views/errors/no_account.htmlREADME.mdlib/users.jsmeteor/packagespackages/cb-theme/lib/client/stylesheets/screen.scssAccounts.onCreateUserclient/views/errors/no_account.jsserver/users.jslib/config/at_config.jsclient/views/users/social_login.jsclient/views/users/social_login.htmlserver/oauth_config.jsThis PR was generated by Freelance Agent using Claude Code