Don't try to send through closed socket in NodeDiscovery#82
Open
Wolf480pl wants to merge 1 commit intoethereum:developfrom
Open
Don't try to send through closed socket in NodeDiscovery#82Wolf480pl wants to merge 1 commit intoethereum:developfrom
Wolf480pl wants to merge 1 commit intoethereum:developfrom
Conversation
When stopping the services, and PeerManager is still alive after NodeDiscovery was stopped, it may try to send some discovery messages. This will cause DatagramServer.sendto to throw AttributeError, because a closed DatagramServer doesn't have a `socket` attribute. Prevent this, by checking if the DatagramServer is closed, and dropping the message if it is.
3 similar comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stopping the services, and PeerManager is still alive after
NodeDiscovery was stopped, it may try to send some discovery messages.
This will cause DatagramServer.sendto to throw AttributeError, because
a closed DatagramServer doesn't have a
socketattribute.Prevent this, by checking if the DatagramServer is closed, and dropping
the message if it is.