Conversation
While adding this, I discovered that the fallback service was overwritten by a 404 fallback, so static files were not being served correctly from the root URL: http://glados/ This 404 handler was first added in ethereum#64 but this seems to have been a mistake, since the fallback doesn't get invoked in the use case for the issue. I confirmed that 404s are still returned by a missing url like: http://glados/UNSUPPORTED_PATH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add a test that routing to static files from the root path works.
I made some progress, but ran out of time so I have to pause work on it for now.