feat: adds fourfours strategy to glados-audit#231
Merged
mrferris merged 2 commits intoethereum:masterfrom Feb 22, 2024
Merged
Conversation
mrferris
force-pushed
the
4444audits
branch
4 times, most recently
from
30ebd61 to
17c165d
Compare
mrferris
force-pushed
the
4444audits
branch
2 times, most recently
from
ec28ee5 to
f37b7d2
Compare
looks cool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem?
The approach to 4444s stats taken in #230 requires pre-loading the DB with all 45mil+ content keys. This is quite an operational overhead.
What's the solution?
This PR adds a dedicated
FourFoursaudit strategy that has access to aWeb3provider that it uses to randomly select hashes for blocks between genesis and merge, stores their content keys in the DB, and then audits them.It also adds 4444s statistics to the front page, and the filtering option to the Audit Dashboard.