Add testing_buildBlockV1 RPC Method#747
Draft
MysticRyuujin wants to merge 8 commits intoethereum:mainfrom
Draft
Conversation
…ures This commit adds comprehensive support for the testing_buildBlockV1 RPC method, which is used to generate test fixtures for Ethereum execution layer clients. Changes include: - New OpenRPC specification in src/testing/testing_buildBlockV1.yaml - Test fixtures for three scenarios: with transactions, with extra data, without extra data - Integration of testing methods into spec build process (scripts/build.js) - Client configuration to enable testing RPC namespace (tools/client.go) - Test generator implementation with comprehensive validation (tools/testgen/generators.go) - Wordlist update for spellcheck compliance All tests pass: ✅ npm run lint (OpenRPC validation) ✅ npm run test (speccheck validation) ✅ Spellcheck The implementation follows existing patterns and is backward compatible.
Author
|
This PR is in draft mostly because of the requirement to use MariusVanDerWijden/testing-buildblock and it is directly addressing testing for #710 as well as some other minor issues found while running the complete test suite. Also, I'm getting some errors with the branch/fork of geth, which I think are actual geth bugs. |
Author
|
Ok, now the tests are passing, but these changes still need to make it into go-ethereum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive support for the testing_buildBlockV1 RPC method.
Changes
Testing Results
✅ All npm lint checks passing
✅ All speccheck tests passing
✅ Spellcheck validation passing