Add EIP-7928 Block-level Access Lists JSON RPC methods#726
Add EIP-7928 Block-level Access Lists JSON RPC methods#726nerolation wants to merge 6 commits intoethereum:mainfrom
Conversation
|
Is there a test for 4444 "pruned history unavailable" or perhaps that not possible with the current hivenet? Also, maybe a silly question but how will the node know the difference between non-existing and pruned? Otherwise lgtm |
|
No, there's none on that. Wasn't sure about this one but if you say it makes sense to add one, let's do it. |
mkalinin
left a comment
There was a problem hiding this comment.
The spec and tests look good!
|
It's not clear from the naming of I would suggest naming the two endpoints something like:
This naming would be consistent with other RPCs such as:
|
| - name: eth_getBlockAccessListByBlockNumber | ||
| summary: Returns the block access list for a block by number. | ||
| params: | ||
| - name: Block |
There was a problem hiding this comment.
Should this be named 'Block number' instead of 'Block'?
There was a problem hiding this comment.
Yeah agree, will change it
There was a problem hiding this comment.
Kept it as-is as this also allows inputs like "latest"
|
We have just merged the test generator into this repo, so it's easier now to add the testse. The tests need to be added to the generator in https://github.com/ethereum/execution-apis/blob/main/tools/testgen/generators.go and then recreated. |
|
Why do these methods return |
Yeah agree. Should be incorporated for amsterdam-devnet-3 |
Add RPC methods for EIP-7928 Block-level Access Lists
This PR introduces two new RPC methods to query block-level access lists (BALs) as defined in EIP-7928:
eth_getBlockAccessListByHash— returns the BAL for a block by hasheth_getBlockAccessListByNumber— returns the BAL for a block by number or tagBlockstructure.BlockAccessListnaming to avoid confusion with EIP-2930 transaction access lists.