eth: add eth_config API definitions for EIP-7910#678
Open
shemnon wants to merge 7 commits intoethereum:mainfrom
Open
eth: add eth_config API definitions for EIP-7910#678shemnon wants to merge 7 commits intoethereum:mainfrom
shemnon wants to merge 7 commits intoethereum:mainfrom
Conversation
Implements the eth_config JSON-RPC method as specified in EIP-7910 to provide comprehensive fork configuration details including current, next, and last fork configurations with their respective hashes and fork IDs. Changes: - Add eth_config method definition in src/eth/client.yaml - Add ConfigurationResponse, ConfigObject, and BlobSchedule schemas - Add bytes4 base type for CRC-32 hashes and fork IDs - Add test cases for different scenarios
Signed-off-by: Danno Ferrin <danno@numisight.com>
bomanaps
reviewed
Jul 27, 2025
Co-authored-by: Mercy Boma Naps Nkari <96525594+bomanaps@users.noreply.github.com>
Co-authored-by: Mercy Boma Naps Nkari <96525594+bomanaps@users.noreply.github.com>
- Remove configHash fields from ConfigurationResponse - Move forkId fields into ConfigObject - Invert precompiles map: name->address mapping with alphabetical sorting - Update test cases to match EIP specification format Signed-off-by: Danno Ferrin <danno@numisight.com>
…cution-apis into eip-7910-eth_config Signed-off-by: Danno Ferrin <danno@numisight.com>
…scheduled. Signed-off-by: Danno Ferrin <danno@numisight.com>
lightclient
reviewed
Aug 20, 2025
Member
lightclient
left a comment
There was a problem hiding this comment.
Generally LGTM. How were the tests generated? Would be good if we have that in rpctestgen before merging.
Contributor
Author
|
Tests were generated from the reference implementation and cross-compared with fork definitions. |
3 tasks
Contributor
|
We have to create these tests with rpctestgen before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the eth_config JSON-RPC method as specified in EIP-7910 to provide comprehensive fork configuration details including current, next, and last fork configurations with their respective hashes and fork IDs.
Changes: