feat(mypy): add some type hints in decoding.py#251
Open
BobTheBuidler wants to merge 2 commits intoethereum:mainfrom
Open
feat(mypy): add some type hints in decoding.py#251BobTheBuidler wants to merge 2 commits intoethereum:mainfrom
BobTheBuidler wants to merge 2 commits intoethereum:mainfrom
Conversation
I noticed you're currently working on the repo and already had these ready from my work on faster-eth-abi I could port over some other type hints too if I know it would be desired, but I don't want to spend time doing so if the PRs will sit there for 6 months.
Contributor
Author
|
I didn't add a release note for this PR, it seems unnecessary for this case but I can still add one if you prefer |
* Update code_of_conduct.rst making -> make * Update contributing.rst newsfragment should not be italics * osx -> macos * Add docs check to pre-release process * Update license year in docs/conf * ignore tests folder when building docs * lower pin on wheel to post-ReDoS fix: (#138) - We got this notice on `pyrlp`: https://github.com/ethereum/pyrlp/security/dependabot/2 - Better to be safe and lower pin ``wheel``. * Drop python 3.8 and 3.9 support, add 3.14 * Remove deprecated license specification Rely instead on the license classifier a few lines down * Update mypy version * Update pyupgrade version requirement in pre-commit config (#144) * Lint fixes * Fix typing * Remove hypothesis warnings * Add newsfragments for #250 * Fix docs/contributing * Compile release notes for v6.0.0-beta.1 * Bump version: 5.2.0 → 6.0.0-beta.1 * feat: optimize encode and decode - cache tuple encoder/decoder objects for reuse - implement in codec - Update registry.py * newsfragment for #246 --------- Co-authored-by: Paul Robinson <5199899+pacrob@users.noreply.github.com> Co-authored-by: fselmo <fselmo2@gmail.com> Co-authored-by: kclowes <kclowes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed you're currently working on the repo and already had these ready from my work on faster-eth-abi, decided I'd contribute them back to the main repo so everybody can benefit!
I think I have most of the library properly typed. I could port over some other type hints too if I know it would be desired, but I don't want to spend time doing so if the PRs will sit there for 6 months. Lmk if this would be a welcome addition or not.
Todo:
Cute Animal Picture