OZ audit low severity fixes#2748
Conversation
Also fixes OZ-N-06 which was a single typo.
fixup! contracts: Fix OZ-N-03 Complex ERC165 implementation
fixup! contracts: Fix OZ-N-03 Complex ERC165 implementation
This commit also expands on the natspec comments to clarify how the additional data may be used. fixup! contracts: Fix OZ-M-05 rename _data to _extraData
|
maurelian
changed the title
maurelian
force-pushed
the
m/low-oz-fixes
branch
from
6eb548e to
540caad
Compare
|
There is no changeset here, because contracts-bedrock was not a package at this point in history. |
|
Do we need to pull this into the current version of the codebase? |
|
I propose we make a simultaneous PR that commits these changes into develop |
Good call, I'll do that. I'm having some trouble getting the patch to apply, atm though, and don't think it should block this so we can pass back to OZ. |
|
Merging this. |
Updates execution dependencies.
2 participants
This PR fixes the Low and Informational severity issues issues in the OpenZeppelin audit (which is not yet public). Each commit in this PR clearly references the finding that it addresses.
In order to review, I suggest comparing between the audit report (see the "Open Zeppelin Audit Resolution" doc in Notion), and the commit which mentions it.
In order to ensure that the changes are applied to the original audit code, this PR is being applied to the state of the develop branch as it was immediately after merging the bedrock branch (#2563).