-
Notifications
You must be signed in to change notification settings - Fork 3.9k
test: zk dispute game factory and registry #19872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xChin
wants to merge
25
commits into
ethereum-optimism:develop
Choose a base branch
from
defi-wonderland:test/zk-dispute-game-factory-and-registry
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9ccc54d
test: add ZK DGF tests
0xChin f868731
test: restructure ZK dispute game factory tests into dedicated contracts
0xChin 3946a3f
test: add bond overpayment scenario
0xChin 34ff082
chore: pre-pr
0xChin 661f1c6
test: add ZK dispute game tests for AnchorStateRegistry
0xChin 84923be
chore: run just pr
0xChin c15f8c5
Merge branch 'develop' into test/zk-dispute-game-factory-and-registry
0xChin a02e5d6
refactor: use vars instead of magic numbers
0xChin 107747f
test: do assertions over exact values
0xChin 818ca5b
refactor: add zkCreateParams helper function for reused logic
0xChin 27d0889
test: check findLatestGames works if n > gameCount
0xChin dfe8893
test: check notRegistered path in ASR ZKDisputeGame test
0xChin 38a5518
test: add fuzz testing
0xChin b864e08
test: add more fuzz tests
0xChin e1d31f8
refactor: use IDisputeGame interface
0xChin 46e6ce0
refactor: add reused vars/logic in init contract
0xChin a651fe6
chore: run just pr
0xChin 4b80e5b
fix: just-upgrade CI failing
0xChin c41aa6f
chore: run just pr
0xChin e8910df
Merge branch 'develop' into test/zk-dispute-game-factory-and-registry
0xChin f64a2c6
feat: remove skip
ashitakah 92e894d
fix(ci): resource-intensive test breaking CI
0xChin e97e928
test: increase test coverage in ASR
0xChin 9d6cb9f
refactor: remove redundant oneliner
0xChin 1a786ef
test: ensure same state after revert in ASR
0xChin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every this is testes when zk dispute game is enabled. Maybe create one to check that reverts if the flag is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the flag disabled, the ZK game implementation wouldn't be deployed or registered in the factory so there's no
zkGameProxyto test against. The ASR and factory are game-type agnostic; they don't check the feature flag themselves. The flag only gates deployment at the OPCM level, which is already covered bytest_upgrade_enableZKGameWithoutDevFeature_revertsin the OPCM tests. At the ASR/factory level, "flag disabled" just means "no ZK game exists," which isn't a ZK-specific scenario worth testing here.