Skip to content

feat: unified predeploys source of truth#19847

Draft
0xniha wants to merge 16 commits intodevelopfrom
feat/l2cm-predeploys-sot
Draft

feat: unified predeploys source of truth#19847
0xniha wants to merge 16 commits intodevelopfrom
feat/l2cm-predeploys-sot

Conversation

@0xniha
Copy link
Copy Markdown
Contributor

@0xniha 0xniha commented Mar 31, 2026

Description
Add unified predeploys source of truth

Closes #19260

@0xniha 0xniha self-assigned this Mar 31, 2026
@0xniha
Copy link
Copy Markdown
Contributor Author

0xniha commented Mar 31, 2026

/ci authorize 2814901

@0xniha
Copy link
Copy Markdown
Contributor Author

0xniha commented Apr 1, 2026

/ci authorize 7cadd7e

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 93.58974% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.0%. Comparing base (adc0717) to head (7f71863).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...es/contracts-bedrock/src/L2/L2ContractsManager.sol 0.0% 3 Missing ⚠️
...ges/contracts-bedrock/src/libraries/Predeploys.sol 97.3% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19847      +/-   ##
===========================================
+ Coverage     75.8%    81.0%    +5.2%     
===========================================
  Files          684      140     -544     
  Lines        73114     7321   -65793     
===========================================
- Hits         55431     5934   -49497     
+ Misses       17539     1387   -16152     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.0% <93.5%> (+0.3%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/contracts-bedrock/src/libraries/Predeploys.sol 96.6% <97.3%> (+29.1%) ⬆️
...es/contracts-bedrock/src/L2/L2ContractsManager.sol 0.0% <0.0%> (ø)

... and 544 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xniha
Copy link
Copy Markdown
Contributor Author

0xniha commented Apr 1, 2026

/ci authorize cdcff62

if (records[i].sysFeatureGate != 0) {
// If the feature on the gate is not present on the bitmap, the predeploy is not supported.
if (
DevFeatures.isDevFeatureEnabled(records[i].sysFeatureGate, Features.CUSTOM_GAS_TOKEN)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the proper way to check for system features status? Dev Feature Flags are bitmaps while Features are human readable tags with a status stored somewhere as a boolean flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[L2CM] Refactor to establish a source of truth for predeploys and ensure parity between L2Genesis and L2CM upgrades

3 participants