-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: shared dispute game migration for interop #19840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stevennevins
wants to merge
34
commits into
develop
Choose a base branch
from
feat/interop-shared-dispute-game
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
043a081
feat: integrate SysFeature for Interop
stevennevins cf9b369
feat: add interop migration functions and eth lockbox to portal2
stevennevins 176d624
chore: rename function to migrateToSharedDisputeGame
stevennevins ab13d5a
chore: bump snapshots
stevennevins a9f3041
fix: use Portal2 in OPCM migrator
stevennevins 397413f
fix: semver bumps from interface change
stevennevins c4346c8
fix: only overwrite the lock box when passing non-zero value
stevennevins 273b28c
chore: update comments to refer to OptimismPortal2 instead of Optimis…
stevennevins 086170c
fix: mismatched names
digorithm 816b8d3
fix: enable INTEROP feature flag in v1 OPCM deploy path
digorithm 5ce845f
fix: remove casting to OptimismPortalInterop
stevennevins e4b6d26
chore: remove OptimismPortalInterop dead code
stevennevins 9638b9d
chore: update comment to remove OptimismPortalInterop
stevennevins 1911c8a
chore: remove OptimismPortalInterop specific tests since we now test …
stevennevins d2240e9
fix: test name camelCase
stevennevins e511f27
chore: remove OptimismPortalInterop from Initializable tests and remo…
stevennevins 22c57f5
fix: restore superRootsActive flag in super-roots withdrawal proof tests
digorithm 8294268
Merge branch 'feat/interop-shared-dispute-game' of https://github.com…
digorithm 4fbe810
fix: normalize INTEROP feature in SystemConfig fuzz test
digorithm fc31aee
chore: add references for OptimismPortalInterop removal issue
stevennevins 6d72d2d
chore: remove stale comment about superRootsActive
stevennevins d0499e7
fix(portal): bump OptimismPortal2 version and fix OPCM_V2 interop upg…
stevennevins 81ea957
chore: update checks for superRootActie to be for the INTEROP feature…
stevennevins b6e6cb4
fix: standard validator assertions to be for Portal2 instead of Porta…
stevennevins 44e4c48
fix: change event params back to non-indexed versions
stevennevins b6886db
chore: clean up branching logic for portal/opcm feature flags
stevennevins f0c6490
chore: refactor the checks in assertValidPortal
stevennevins e1bd3ef
chore: organize functions by visibility
stevennevins d0f0baa
fix: implement the _assertValidInteropState helper and add to initalize
stevennevins ac4eda6
fix: update assert for INTEROP flag instead of superroots active
stevennevins 8097395
chore: add clarification to the comment about the prerequisites to th…
stevennevins 3e417af
chore: add TODO issue tracking for follow up removal
stevennevins 7ca8a76
fix: add missing OptimismPortal_InvalidInteropState error to IOptimis…
digorithm 6f4c1bd
fix: assertions for the forked upgrade scenario
stevennevins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom error
OptimismPortal_NotUsingInteropviolates the Optimism Solidity Style Guide naming convention for errors. Custom errors should take the formatContractName_ErrorDescription. Since this is in the IOptimismPortal2 interface, it should be namedOptimismPortal2_NotUsingInteropto match the contract name.Spotted by Graphite (based on custom rule: Solidity Style Guide)

Is this helpful? React 👍 or 👎 to let us know.