-
Notifications
You must be signed in to change notification settings - Fork 3.9k
refactor(contracts): remove OPCMv1 from all Solidity code #19795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smartcontracts
wants to merge
24
commits into
develop
Choose a base branch
from
chore/remove-opcmv1-solidity
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b8d0fec
refactor(contracts): remove OPCMv1 from all Solidity code
smartcontracts 6d35eae
fix(contracts): keep deprecated v1 struct fields for Go ABI compat
smartcontracts 161c60c
fix(op-deployer): remove v1 OPCM branching to match Solidity changes
smartcontracts 0dc1947
fix(op-deployer): populate OpcmImpl with v2 address for downstream co…
smartcontracts 2ed262f
fix(op-devstack): remove v1 migrate path, use v2 migrator ABI
smartcontracts 97906ad
fix(op-deployer): update test assertions for v1 OPCM removal
smartcontracts 475e3b6
fix(op-devstack): remove unused getInteropCannonKonaAbsolutePrestate
smartcontracts a4488a0
fix: update tests for v1 OPCM removal
smartcontracts d868b52
fix(op-devstack): use V2 upgrade path for addGameType
smartcontracts f6a9e11
fix(op-devstack): send all 3 game configs in V2 upgrade
smartcontracts fc72fd3
fix: use OpcmV2 in interopgen and apply tests
smartcontracts b98d3af
fix: use V2 migrate input in interopgen, fix apply test
smartcontracts a9b68c7
fix(op-deployer): set OpcmV2Impl in init when OPCM is pre-deployed
smartcontracts e6c3cb3
chore: regenerate semver-lock.json after rebase
smartcontracts e9312d8
fix(contracts): add missing imports after rebase conflict resolution
smartcontracts 0c60343
fix(op-devstack): send all 6 game configs for V2 upgrade
smartcontracts 3ca3d64
fix(op-e2e): include tx value in proposer sendTx for init bond
smartcontracts 2f65b01
fix(interopgen): register SUPER_CANNON in migrate DisputeGameConfigs
smartcontracts 8a088a6
fix(op-devstack): register all super game types in migrate
smartcontracts ab7d24d
fix: goimports formatting in superroot.go
smartcontracts d0a920f
fix: review improvements — version guards, artifact ABI, stale bindings
smartcontracts 451a1ee
fix(interopgen): register Super Cannon Kona game type in V2 migration
smartcontracts c731b04
fix(contracts): restore and migrate StandardValidator tests to V2
smartcontracts 28f23d2
chore: remove narration comments about v1/v2 migration
smartcontracts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can just remove this entirely now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
op-deployer/pkg/deployer/opcm/add_game_type.go:119 also references
AddGameType.s.solThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will handle in follow-up PR