This repository was archived by the owner on Apr 11, 2021. It is now read-only.
Open
Conversation
…ation into feat/conditional_mount
tynes
reviewed
Mar 12, 2021
| #!/bin/bash | ||
|
|
||
| git pull --recurse-submodules | ||
| git pull origin master --recurse-submodules |
Collaborator
There was a problem hiding this comment.
This needs smarter logic about the current head
tynes
reviewed
Mar 12, 2021
| .PHONY: all integration-tests deployer geth-l2 batch-submitter data-transport-layer test | ||
|
|
||
| pull: | ||
| @echo "Pulling & building all remote images..." |
Collaborator
There was a problem hiding this comment.
pull.sh is broken so i don't think we should recommend using it until it is fixed
…ation into feat/conditional_mount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses https://github.com/ethereum-optimism/roadmap/issues/660 by making it so that the
-lflag requires specific packages to be passed through. This prevents the anti-pattern in this repo where you feel you have to always build local all of the packages to test.TODO:
-[ ] Determine what to do about make 😭 I deleted everything that isn't building because I got frustrated about not being able to pass through args 😅 but maybe I should re-add the stuff.