This repository was archived by the owner on Apr 11, 2021. It is now read-only.
Open
Conversation
Contributor
|
Oh actually how much work would it be to remove the node dependency? |
karlfloersch
suggested changes
Feb 22, 2021
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
Hmm ok honestly I think it's probably worth removing node dependency but ughhh I don't want this to take a lot of time 😭
Just not great practice to introduce a node dep for something like this lol
tynes
commented
Mar 5, 2021
| # The `-l` flag will use mounted code. | ||
|
|
||
| VERSION=$(docker-compose --version) | ||
| node -e " |
Collaborator
Author
There was a problem hiding this comment.
We should remove the dependency on node, this should be possible to do with sed or awk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a dependency on
nodebut prints a warning if thedocker-composeis too old