feat: raw tx

[karlfloersch]

Description

Makes L2Geth operate on raw tx data!

Metadata

Fixes

• Fixes # [Link to Issue]

Contributing Agreement

• I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

[karlfloersch]

Maybe we should rename RawTransaction to RawBlob? or Raw? Or idk

[karlfloersch]

Also @tynes you might want to add to this PR & delete all the newly dead code in the sync service? I assume there is dead code there? Or maybe there isn't? Idk

[tynes]

Assuming the upgrade to use standard RLP serialization, this will be able to be removed

[smartcontracts]

I just tried this branch against my WIP encoding PR (https://github.com/ethereum-optimism/contracts/pull/300/files) and replaced getRawTransaction(*tx) with rlp.EncodeToBytes(tx) and it worked first try. Woot!

[tynes]

newRPCTransaction needs updating still

go-ethereum/internal/ethapi/api.go

Line 1201 in bfa3007

func newRPCTransaction(tx *types.Transaction, blockHash common.Hash, blockNumber uint64, index uint64) *RPCTransaction {

Update:
This has been addressed in 559e171

[tynes]

This results in mismatched state roots. To reproduce:

$  ./scripts/start.sh --rollup.clienthttp http://127.0.0.1:7878 --verifier --datadir $HOME/.ethereum --rollup.statedumppath https://raw.githubusercontent.com/ethereum-optimism/regenesis/master/mainnet/1.json

From https://github.com/ethereum-optimism/scripts

$ VERIFIER_ENDPOINT=http://127.0.0.1:8545 SEQUENCER_ENDPOINT=https://mainnet.optimism.io node scripts/verifier/compare-verifier-sequencer.js

The compare-verifier-sequencer.js script will find the first mismatched state root. I think it has to do with the enum for tx type

[tynes]

I've updated a branch in the contracts repo based on the contracts that are currently deployed to production to include the fixes required to get this to work.

The branch is found here:
https://github.com/ethereum-optimism/contracts/tree/v0.1.4/enums
From within the repo, run the command:

$ yarn serve

Then when starting geth, use the flag:

--rollup.statedumppath http://127.0.0.1:8081/state-dump.latest.json

Doing a state root check will not be sufficient since the genesis state roots will be different since this involves a change to the contract code of a predeploy. Working towards syncing mainnet and then will do a state diff to see if there are any differences. The only difference should be the codeHash for the sequencer entrypoint

[tynes]

With the addition of 3319556 then ethereum-optimism/contracts#303 is not needed to be merged and it will also prevent more difficulties in managing versions and we can move towards ethereum-optimism/contracts#300

[tynes]

f2114cb adds a safety check with an error log if a transaction with no raw is detected. This should never happen but will prevent a panic in case it does