This repository was archived by the owner on Apr 12, 2021. It is now read-only.
[WIP] Clarifying comments for chainID recovery logic#272
Closed
platocrat wants to merge 3 commits intoethereum-optimism:masterfrom
Closed
[WIP] Clarifying comments for chainID recovery logic#272platocrat wants to merge 3 commits intoethereum-optimism:masterfrom
platocrat wants to merge 3 commits intoethereum-optimism:masterfrom
Conversation
platocrat
changed the title
platocrat
changed the title
platocrat
changed the title
maurelian
reviewed
Mar 5, 2021
test/helpers/codec/encoding.ts
Outdated
| data: `0x${'99'.repeat(10)}`, | ||
| /** | ||
| * @dev Encoding `chainId` | ||
| */ |
Collaborator
There was a problem hiding this comment.
this comment feels a bit disruptive, could we just append it after the line? ie.
chainId: 420, // Encoding chainId
test/helpers/codec/encoding.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * @dev Trace where `DEFAULT_EIP155_TX` is called. |
Author
There was a problem hiding this comment.
Sorry, these were personal comments I was using as reminders
platocrat
force-pushed
the
comments/for-chainid
branch
from
07fa78c to
04ff27c
Compare
Collaborator
|
@platocrat I'm converting this to draft status for now. Please mark it as ready for review when appropriate. :) |
Author
|
Almost forgot about this. I had added only a few comments |
maurelian
reviewed
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This is a draft
DEFAULT_EIP155_TXwhich setschainIdto 420.DEFAULT_EIP155_TXworks and where it's used (where needed inOVM_<CONTRACT>.spec.ts).Questions
Fixes
Contributing Agreement