This repository was archived by the owner on Apr 11, 2021. It is now read-only.
Unit add to Variable Update run-batch-submitter.ts#50
Open
walkingbackward wants to merge 1 commit intoethereum-optimism:masterfrom
Open
Unit add to Variable Update run-batch-submitter.ts#50walkingbackward wants to merge 1 commit intoethereum-optimism:masterfrom
walkingbackward wants to merge 1 commit intoethereum-optimism:masterfrom
Conversation
Added: MS after POLL_INTERVAL Added: S after MAX_SUBMISSION_TIME
| parseInt(requiredEnvVars.MAX_BATCH_SUBMISSION_TIME, 10) * 1_000, | ||
| parseInt(requiredEnvVars.MAX_BATCH_SUBMISSION_TIME_S, 10) * 1_000, | ||
| parseInt(requiredEnvVars.NUM_CONFIRMATIONS, 10), | ||
| parseInt(requiredEnvVars.RESUBMISSION_TIMEOUT, 10) * 1_000, |
There was a problem hiding this comment.
This could also be changed to RESUBMISSION_TIMEOUT_S
|
I think we need to change our types somewhere. |
| MAX_BATCH_SIZE: 'MAX_BATCH_SIZE' | ||
| // The maximum amount of time (seconds) that we will wait before submitting an under-sized batch. | ||
| MAX_BATCH_SUBMISSION_TIME: 'MAX_BATCH_SUBMISSION_TIME' | ||
| MAX_BATCH_SUBMISSION_TIME: 'MAX_BATCH_SUBMISSION_TIME_S' |
There was a problem hiding this comment.
Suggested change
| MAX_BATCH_SUBMISSION_TIME: 'MAX_BATCH_SUBMISSION_TIME_S' | |
| MAX_BATCH_SUBMISSION_TIME_S: 'MAX_BATCH_SUBMISSION_TIME_S' |
Ahhh ok I see the issue -- we have to change the keys here too.
Author
There was a problem hiding this comment.
I created a new pull request with new changes. Tried to edit this existing pull request, but could not figure it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added: MS after POLL_INTERVAL
Added: S after MAX_SUBMISSION_TIME