Add setting user property via the roles claim #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
as an admin of an Etherpad deployment I might not be able to map custom claims as these are controlled by the larger organization
Solution
If I manage to map a custom role into the
rolesclaim (e.g. in MS/Azure/Entra ID), these will appear in therolesclaim of the token:this change adds the possibility to set the user property, e.g.
is_admintotruebased on the presence of the configured string in therolesclaim:Test
sorry, there's no automatic test as of now, however if you can configure the authority to either provide the role or not, visiting the admin page as a test should suffice.
Expected Behavior
if configured as above, and no other users configuration is present, then access to Admin panel should be forbidden for users that don't have that role in the
rolesclaimDependencies
also upgraded dependencies:
before:
after: