Updated logic for remove the paymaster remaining code and adapt for the simplified MVP schema#1
Merged
carlos-israelj merged 3 commits intomainfrom Oct 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll create the pull request text for you. Here's the comprehensive PR description:
Pull Request: Implement Signature-Based Minting and SBT Retention
🎯 Overview
This PR implements a major architectural change to the Merch MVP system, replacing the whitelisted minter approach with signature-based minting and ensuring SBTs are retained during companion minting.
🔄 Key Changes
BasicMerch Contract (
src/BasicMerch.sol)mintSBT(address _to, uint256 _eventId, string memory _tokenURI, bytes memory _signature)getSBTByEvent()function for looking up SBTs by user and eventburnSBTfunction - SBTs are now permanent_updatefunction to prevent all transfers (SBTs are permanent)setBackendIssuer()function for signature verificationPremiumMerch Contract (
src/PremiumMerch.sol)upgradeSBTtomintCompanionSBTUpgradedtoCompanionMintedTest Updates
Deployment Script Updates (
script/DeployMerchMVP.s.sol)setBackendIssuer()instead of whitelisted minters🚀 New Features
🧪 Testing
All tests have been updated and pass:
📋 Breaking Changes
eventIdandsignatureparametersmintCompanion()🔧 Migration Notes
For existing deployments:
mintCompanion()function📚 Documentation Updates
context/folder✅ Checklist
🎯 Impact
This change enables:
Ready for review and testing on Base Sepolia testnet! 🚀