Swaps the order of newpixNumber update and ONGBase calculations so they are in the correct order#1540
Open
Eregrith wants to merge 1 commit intoeternaldensity:masterfrom
Open
Swaps the order of newpixNumber update and ONGBase calculations so they are in the correct order#1540Eregrith wants to merge 1 commit intoeternaldensity:masterfrom
Eregrith wants to merge 1 commit intoeternaldensity:masterfrom
Conversation
…ey are in the correct order Fixes issue eternaldensity#1539
RedundantCueball
suggested changes
Oct 27, 2024
RedundantCueball
left a comment
RedundantCueball
left a comment
There was a problem hiding this comment.
The problem does exist, but I don't think the solution will be that easy...
On Line 3739, inside function Molpy.ONGBase, it is testing the Molpy.newpixNumber in order to give a boost.
If the Molpy.newpixNumber increment happens before (it happens on the todo function), there will be problems...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1539
While reviewing, please make sure the rest of the ONGs subfunctions are OK to be done before calling ONGBase