Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/hn.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ var InlineReply = {
$(this).attr("value","Posting...");
//Add loading spinner
image = $('<img style="vertical-align:middle;margin-left:5px;"/>');
image.attr('src',chrome.extension.getURL("images/spin.gif"));
image.attr('src',chrome.runtime.getURL("images/spin.gif"));
$(this).after(image);
//Post
InlineReply.postCommentTo(link, domain, text, $(this));
Expand Down Expand Up @@ -261,7 +261,7 @@ var CommentTracker = {
}
}

var unvoteImg = chrome.extension.getURL("images/unvote.gif");
var unvoteImg = chrome.runtime.getURL("images/unvote.gif");

class HNComments {
constructor(storyId) {
Expand Down Expand Up @@ -462,7 +462,7 @@ class HNComments {

c.el = commentEl;

tagImageEl.src = chrome.extension.getURL('/images/tag.svg');
tagImageEl.src = chrome.runtime.getURL('/images/tag.svg');

commentEl.id = c.id;
commentEl.classList.add(`level-${oddOrEven}`);
Expand Down
28 changes: 21 additions & 7 deletions manifest.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"name": "Hacker News Enhancement Suite",
"short_name": "HNES",
"version": "1.6.0.3",
"version": "1.7.0.0",
"description": "Hacker News Enhanced.",
"manifest_version": 2,
"manifest_version": 3,
"background": {
"scripts": ["background.js"]
"service_worker": "service_worker.js",
"type": "module"
},
"permissions": [
"storage",
Expand Down Expand Up @@ -55,9 +56,22 @@
}
],
"web_accessible_resources": [
"images/spin.gif",
"images/unvote.gif",
"images/tag.svg",
"templates/comment.html"
{
"resources": [
"images/spin.gif",
"images/unvote.gif",
"images/tag.svg",
"templates/comment.html"
],
"matches": [
"http://news.ycombinator.com/*",
"https://news.ycombinator.com/*",
"http://news.ycombinator.net/*",
"https://news.ycombinator.net/*",
"http://hackerne.ws/*",
"https://hackerne.ws/*",
"http://news.ycombinator.org/*",
"https://news.ycombinator.org/*"]
}
]
}
14 changes: 7 additions & 7 deletions background.js → service_worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {
console.log('REQUEST', request.method, request)
if (request.method == "getAllLocalStorage") {
sendResponse({data: localStorage});
sendResponse({data: chrome.storage.local});
}
else if (request.method == "getLocalStorage") {
sendResponse({data: localStorage[request.key]});
sendResponse({data: chrome.storage.local[request.key]});
}
else if (request.method == "setLocalStorage") {
localStorage[request.key] = request.value;
chrome.storage.local[request.key] = request.value;
sendResponse({});
}
else if (request.method == "getUserData") {
Expand All @@ -24,18 +24,18 @@ function getUserData(usernames) {
var results = {};
for (var i = 0; i < usernames.length; i++) {
var key = usernames[i],
value = localStorage[key];
value = chrome.storage.local[key];
results[key] = value;
}
return results;
}

//expire old entries
(function() {
for (i=0; i<localStorage.length; i++) {
var info = JSON.parse(localStorage[localStorage.key(i)]);
for (i=0; i<chrome.storage.local.length; i++) {
var info = JSON.parse(chrome.storage.local[chrome.storage.local.key(i)]);
var now = new Date().getTime();
if (now > info.expire)
localStorage.removeItem(localStorage.key(i));
chrome.storage.local.removeItem(chrome.storage.local.key(i));
}
});