Add widget for geopoint field#60
Add widget for geopoint field#60cbenz wants to merge 31 commits intoetalab:masterfrom multi-coop:58-geopoint-widget
Conversation
|
@geoffreyaldebert a first preview of geopoint widget:
To test geopoint widget locally, use localtunnel.
npm run serve
lt --port 8081 --local-host localhost --subdomain csvgg
|
geoffreyaldebert
left a comment
There was a problem hiding this comment.
Ok for me unless if we take my remark about useless file into account.
.prettierrc
Outdated
| "singleQuote": true, | ||
| "trailingComma": "none", | ||
| "useTabs": false | ||
| } No newline at end of file |
There was a problem hiding this comment.
Is this file useful ? I think we can remove it from PR.
There was a problem hiding this comment.
I find this file useful for the project as it helps a new contributor to work on existing code without breaking code style. I'll remove this file as it has nothing to do with PR subject.
A new PR can be created only to add this file if that makes sense to you.
This file is useful for the project to help a new contributor working on existing code without breaking source indent/format. But
There was a problem hiding this comment.
Ok let's keep it here then.
|
@geoffreyaldebert geopoint widget still uses openstreetmap tiles (https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png) instead of etalab tiles as asked in the issue. Could you give me the etalab tiles url to use to update the PR? |
|
@pierredittgen here is the URL for etalab tiles : https://etalab-tiles.fr/ ? Is this good for you ? |
@geoffreyaldebert do you have any leaflet sample using etalab tiles to create a tile layer? I can't find any :-( |
|
Etalab only provides vector tiles which Leaflet doesn't support out of the box. It's probably easier to stick with raster tiles (not osm.org). Which service do you prefer for free raster tiles? @abulte @geoffreyaldebert @jdesboeufs |
|
Je propose qu'on utilise les tuiles de Jawg.io (Jawg Streets) qui nécessitent un token mais sont gratuites pour un usage non-commercial.
Attribution : |
|
Merci @pierredittgen les tuiles jawg marchent bien ! |
|
Bonjour @geoffreyaldebert, Le nombre de décimales après la virgule se configure via la constante GEO_DECIMAL_COUNT du composant |
|
Très bien, ça marche nickel chez moi, je vais merger. Merci ! Pour historique : le token Jawg s'ajoute dans le fichier .env dans la variable d'environnement |
WIP