Skip to content

Default discriminator value even during edit #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
travjenkins wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Default discriminator value even during edit #1873

travjenkins wants to merge 6 commits into from

Conversation

@travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 20, 2026 •
edited
Loading

Issues

#1866

Changes

1866

  • Need to set the discriminator even during edit.

Tests

Manually tested

  • Create and Edit for a bunch of different connectors. Especially the pydantic ones

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

N/A

@travjenkins travjenkins changed the title Travjenkins/bug/default discriminator on edit Default discriminator value even during edit Jan 20, 2026
@travjenkins travjenkins marked this pull request as ready for review January 20, 2026 20:55
@travjenkins travjenkins requested a review from a team as a code owner January 20, 2026 20:55
@travjenkins travjenkins added the change:planned This is a planned change label Jan 20, 2026
JustinASmith
JustinASmith approved these changes Jan 20, 2026
View reviewed changes
Copy link

@JustinASmith JustinASmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested with source-shopify-native PR for multiple stores and all seems okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JustinASmith JustinASmith JustinASmith approved these changes

@GregorShear GregorShear Awaiting requested review from GregorShear

Assignees

No one assigned

Labels

change:planned This is a planned change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@travjenkins @JustinASmith