dekaf: Add timeout for metadata requests #2102
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
force-pushed
the
dekaf/add_metadata_timeout
branch
5 times, most recently
from
8b151f7 to
fd037ff
Compare
Metadata requests appear to be sometimes hanging forever. We have an idle session timeout, but if a Session is actively handling a request it won't get killed.
jshearer
force-pushed
the
dekaf/add_metadata_timeout
branch
from
7c5ea47 to
ac09fa5
Compare
Contributor
Author
|
Rolled up relevant changes in #2109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata requests appear to be sometimes hanging forever. We have an idle session timeout, but if a Session is actively handling a request it won't get killed, and if that request never returns then we'll effectively leak that connection.
We still absolutely need to figure out why exactly metadata requests are hanging, but for the moment this should alleviate the unbounded connection growth issue Dekaf is seeing.
This change is