feat(pagination): added support to programmatically change active page#44
Open
tomisykora wants to merge 1 commit intoestevanmaito:masterfrom
Open
feat(pagination): added support to programmatically change active page#44tomisykora wants to merge 1 commit intoestevanmaito:masterfrom
tomisykora wants to merge 1 commit intoestevanmaito:masterfrom
Conversation
There are cases where users needs to programmatically change the active page number, eg. when searching, the page should change to first page. resolves estevanmaito#42
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 495 495
Branches 77 77
=========================================
Hits 495 495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The change looks good , any reason why this is not merged yet? @estevanmaito |
|
I need this also, please merged this.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @estevanmaito ! There are cases where users needs to programmatically change the active page number, eg. when
searching, the page should change to first page. So that's what has been added here in this pull request. I also added Pagination storybook and test coverage for this use case. Thanks in advance for looking into it! 😊
This resolves #42