fix permissive build issues with liblo callbacks#50
Open
brulzki wants to merge 1 commit intoessej:masterfrom
Open
fix permissive build issues with liblo callbacks#50brulzki wants to merge 1 commit intoessej:masterfrom
brulzki wants to merge 1 commit intoessej:masterfrom
Conversation
|
I had to do the same changes for arch. To bad I didn't see this before :) Anyway, highly recommend to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building sooperlooper on gentoo fails with a lot of errors related to the gcc -fno-permissive being enabled by default. See the example error below.
This change replaces the 'void *data' parameters in liblo callbacks with 'lo_message data' and so removes those errors without having to enable -fpermissive.
Related gentoo bug: https://bugs.gentoo.org/925275
control_osc.cpp: In member function ‘void SooperLooper::ControlOSC::register_callbacks()’: control_osc.cpp:148:37: error: invalid conversion from ‘int (*)(const char*, const char*, lo_arg**, int, void*, void*)’ to ‘lo_method_handler’ {aka ‘int (*)(const char* , const char*, lo_arg**, int, lo_message_*, void*)’} [-fpermissive] 148 | lo_server_add_method(serv, "/quit", "", ControlOSC::_quit_handler, this); | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | int (*)(const char*, const char*, lo_arg**, int, void*, void*) In file included from /usr/include/lo/lo.h:32, from control_osc.hpp:24, from control_osc.cpp:30: /usr/include/lo/lo_lowlevel.h:876:72: note: initializing argument 4 of ‘lo_method_* lo_server_add_method(lo_server, const char*, const char*, lo_method_handler, const void*)’ 876 | const char *typespec, lo_method_handler h, | ~~~~~~~~~~~~~~~~~~^