fix: skip the org member check for bot users (SRV-171)#116
fix: skip the org member check for bot users (SRV-171)#116kumekay merged 1 commit intoespressif:v1from
Conversation
2878cc0 to
29ea194
Compare
👋 Hello vsaltxx, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
4b938c0 to
efff5df
Compare
|
@vsaltxx Even though it looks more like work around uncommon |
efff5df to
0a641e7
Compare
github.get_user()throwsGithubExceptionfor bot accounts likecopilot[bot]since they aren't regular GitHub users. This crashes the entire Jira sync workflow because the exception is unhandled in both the cron job path (sync_pr.py) and the event handler path (sync_to_jira.py).Changes
sync_pr.py: Wrapget_user()/has_in_members()in_is_collaborator_or_org_member()withtry-except GithubException, treating failure as "not an org member"sync_to_jira.py: Apply the same exception handling to the org membership check inmain()_is_collaborator_or_org_memberwith bot accounts, plus integration tests for both sync pathsLikely fixes #112
Related PR from Copilot: #113