Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Tightens up Wokwi CI/test behavior by improving token detection in tests and passing additional firmware metadata when starting Wokwi simulations.
Changes:
- Update test skip condition to treat empty
WOKWI_CLI_TOKENas “not set”. - Include
flash_sizewhen starting simulations for IDF firmware uploads (flasher_args.json path).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pytest-embedded-wokwi/tests/test_wokwi.py | Adjusts WOKWI token presence check used to skip integration tests. |
| pytest-embedded-wokwi/pytest_embedded_wokwi/wokwi.py | Passes firmware/ELF parameters via a kwargs dict and adds flash_size for IDF firmware simulations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| wokwi_token_required = pytest.mark.skipif( | ||
| os.getenv('WOKWI_CLI_TOKEN') is None, | ||
| not os.getenv('WOKWI_CLI_TOKEN', None), |
There was a problem hiding this comment.
os.getenv('WOKWI_CLI_TOKEN', None) passes None as the default, which is already the default for os.getenv. Consider simplifying to os.getenv('WOKWI_CLI_TOKEN') to reduce noise in this skip condition.
Suggested change
| not os.getenv('WOKWI_CLI_TOKEN', None), | |
| not os.getenv('WOKWI_CLI_TOKEN'), |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.