Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements automatic retry logic for pre-run failures in unity test execution and refactors the Wokwi simulation setup to properly pass flash size parameters.
Changes:
- Added automatic retry with hard reset when test case preparation fails in unity test runner
- Refactored Wokwi simulation setup to consolidate
start_simulationcall and properly passflash_sizeparameter for IDF firmware
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pytest-embedded-wokwi/pytest_embedded_wokwi/wokwi.py | Refactored to build kwargs dictionary before calling start_simulation, adding flash_size parameter for IDF firmware |
| pytest-embedded-idf/pytest_embedded_idf/unity_tester.py | Added retry logic in _run_normal_case and _run_multi_stage_case to handle pre-run failures with hard reset |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
hfudev
force-pushed
the
fix/pre-run-failure
branch
from
0d95616 to
a26de86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #404
also move unit_test_app_esp32, unit_test_app_esp32c3 to the same app unit_test_app_idf with two build dirs.