Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the pytest-embedded-wokwi plugin to support wokwi-client version 0.4.0 by adapting to the new API and removing deprecated version checking code.
Changes:
- Updated wokwi-client dependency from >=0.2.0 to >=0.4.0
- Removed version compatibility checking code and WOKWI_CLI_MINIMUM_VERSION constant
- Updated file upload and simulation initialization to use new wokwi-client 0.4.0 API methods
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pytest-embedded-wokwi/pyproject.toml | Updated wokwi-client minimum version requirement from 0.2.0 to 0.4.0 |
| pytest-embedded-wokwi/pytest_embedded_wokwi/init.py | Removed WOKWI_CLI_MINIMUM_VERSION constant and cleaned up import statements |
| pytest-embedded-wokwi/pytest_embedded_wokwi/wokwi.py | Removed version checking logic and packaging import; updated API calls to use Path objects and new upload_idf_firmware method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @urish I noticed errors like https://github.com/espressif/pytest-embedded/actions/runs/22448984330/job/65011684261#step:6:12904 since wokwi-client 0.4.0 released. This PR is to fix the upload. PTAL, thanks. |
|
@hfudev and was the .bin file actually a compiled firmware file? or something like flasher_args.json? |
I think it's path to the flasher_args.json |
|
But you are calling upload_idf_firmware(), so it should handle that for you: https://github.com/wokwi/wokwi-python-client/blob/419d9d45cac33e464fc6f082b98768f90f2fbebb/src/wokwi_client/idf.py#L36 Do you still get this error when using upload_idf_firmware()? |
72b5f35 to
560ca69
Compare
560ca69 to
6dbc86c
Compare
Added two comments for the commit:
|
No description provided.