Skip to content

fix: duplicated find argument#260

Merged
hfudev merged 1 commit intomainfrom
fix/duplicated-find-argument
Mar 19, 2026
Merged

fix: duplicated find argument#260
hfudev merged 1 commit intomainfrom
fix/duplicated-find-argument

Conversation

@hfudev
Copy link
Copy Markdown
Member

@hfudev hfudev commented Mar 19, 2026

No description provided.

@hfudev hfudev requested a review from Copilot March 19, 2026 03:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a manifest duplication issue triggered when running the find command with manifest_filepatterns provided via config, where FindArguments validation was effectively performed twice and caused duplicate manifest loading.

Changes:

  • Add a regression test ensuring find + config-based manifest_filepatterns does not emit duplicate-manifest warnings.
  • Adjust CLI main() to reuse the existing FindArguments instance for find rather than re-validating from a dumped model.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/test_cmd.py Adds a regression test to ensure manifest patterns from config don’t cause duplicate-manifest warnings on find.
idf_build_apps/main.py Avoids re-validating FindArguments for the find action by reusing the already-constructed model.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread idf_build_apps/main.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
idf_build_apps
   __main__.py330%4–7
   app.py5698286%183, 228, 237–239, 271, 283, 339–340, 342, 351–352, 363–364, 424, 439, 477, 533–541, 551–552, 562, 580–581, 583, 599–608, 626–630, 645–648, 663–664, 682–683, 687–688, 699–701, 707, 720–722, 867–875, 885–915, 919–929, 1024–1030, 1033, 1055, 1075–1079
   args.py3773092%97, 174, 418–423, 433–438, 667, 670–671, 712, 735, 742–743, 755–757, 793–794, 941, 1020, 1022, 1107–1117, 1136
   autocompletions.py292417%16–23, 31–54
   finder.py92496%146, 163–165
   log.py681184%35, 39, 50, 60–69, 114
   main.py2417270%59, 64–68, 115, 120–124, 163, 187–189, 193–194, 200–213, 227–230, 241–270, 360–367, 376–377, 410–417, 420, 426–427, 433–435, 508–523
   session_args.py53787%46–50, 56, 70
   utils.py1822188%91, 108–109, 133, 181, 224, 251–257, 270–273, 287–293, 375
idf_build_apps/junit
   report.py94990%70, 80, 97–99, 125, 132–133, 158
   utils.py291066%18, 26–35
idf_build_apps/manifest
   manifest.py252897%183, 240–245, 352, 382–383, 402, 454
   soc_header.py220%4–6
idf_build_apps/vendors
   pydantic_sources.py58493%63, 66–69
TOTAL216528787% 

Tests Skipped Failures Errors Time
166 0 💤 0 ❌ 0 🔥 10m 32s ⏱️

@hfudev hfudev force-pushed the fix/duplicated-find-argument branch from 540d960 to d876218 Compare March 19, 2026 03:24
@hfudev hfudev merged commit b660e5a into main Mar 19, 2026
8 checks passed
@hfudev hfudev deleted the fix/duplicated-find-argument branch March 19, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants