fix: Remove X-conformance attributes from bridged_device_basic_information validation#15
Conversation
|
@jonsmirl These JSON files are generated using this command, so we shouldn’t edit them manually. |
|
Addressed review feedback - completely reworked the approach: Previous approach (rejected): Manually edited the auto-generated JSON validation files New approach: Updated the parsing logic in Changes made:
Per Matter spec section 9.13.5, these attributes have conformance "X" (SHALL NOT be present) for BridgedDeviceBasicInformation. Verification: Tested with All 79 tests pass. |
625a6f9 to
6b0ddff
Compare
|
Addressed the review feedback - implemented a generic solution as requested. Changes:
How it works: When parsing a derived cluster (like
This approach:
Verification:
|
|
Addressed review feedback:
All 79 tests pass. |
|
@jonsmirl I don’t see any changes in the JSON files from this fix. The X-conformance attributes are still present; only the script was updated. |
|
Regenerated all |
|
@jonsmirl Please consider squashing the commits into an appropriate message and bumping the version in setup.py |
ebd0684 to
e841b9a
Compare
|
Squashed the 4 commits into a single commit and bumped version to 1.0.2 in setup.py. |
…itance When copying attributes from a base cluster to a derived cluster, the tool was not checking whether attributes have disallowed/deprecated/ provisional conformance in the derived cluster. This caused attributes with X-conformance (e.g. Bridged Device Basic Information inheriting from Basic Information) to incorrectly appear in the validation data. - Reuse check_conformance_restrictions from should_process_element to build a skip_list for inherited attributes - Regenerate all validation JSON data files for spec versions 1.2, 1.3, 1.4, 1.4.1, 1.4.2, and 1.5 - Bump version to 1.0.2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
e841b9a to
8e8c64d
Compare
|
Rebased onto main to resolve conflicts from #16. The only conflict was the version number in setup.py — kept it at 1.0.2. |
Summary
Fixes #14
Removes attributes with conformance "X" (SHALL NOT be present) from the
bridged_device_basic_informationcluster requirements in all validation data files.Changes
Per Matter Specification section 9.13.5, the following attributes have conformance X and should NOT be listed as required:
These attributes exist in
BasicInformation(endpoint 0) but are explicitly prohibited fromBridgedDeviceBasicInformationper the Matter spec.Files Modified
dmv_tool/data/validation_data_1.2.json- Removed 3 attributesdmv_tool/data/validation_data_1.3.json- Removed 5 attributesdmv_tool/data/validation_data_1.4.json- Removed 5 attributesdmv_tool/data/validation_data_1.4.2.json- Removed 5 attributesdmv_tool/data/validation_data_1.5.json- Removed 5 attributesTesting
After this fix, devices implementing BridgedDeviceBasicInformation with only the mandatory attributes (Reachable, UniqueID) will pass validation instead of incorrectly failing due to "missing" prohibited attributes.