-
Notifications
You must be signed in to change notification settings - Fork 125
Workflow for avr build #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for avr build #403
Conversation
…nstructions, and added configurable firmware src directory
… the avr runner action
…rsion number easily visible
… by continuous.yml
|
@brentfpage I like the approach documented above and would approve it. Lets see how other maintainers react. The is only a minor nit pick
I'd suggest to change name of variable from AVR_VER to AVR_FIRMWARE_VERSION so its purpose is completely self explanatory |
(Following up on some of the discussion in #381.)
This PR:
The versioning is centralized, but not automatic. Namely, the current version of the firmware has to be set in a repository-wide variable, AVR_VER, under (repo home)->settings->secrets+variables->actions->variables->(repository variables). In the fork, AVR_VER=0x0007. At compile time, this variable gets injected:
It would be nicer to have AVR_VER defined in some location like continuous.yml instead, but it needs to be available to mac.yml when that workflow is called individually. I don't know of any other place to define AVR_VER where it would be available to both workflows.
Also, the inclusion of the version number in the .hex file names has been retained, so they are, e.g., labrafirm_0007_0{1 or 2}.hex. To me, this is worthwhile because then the firmware that's packaged into a given release can be very easily determined.
If we decide to go forward with this approach, extending it to encompass the android, linux, and windows builds I think would be straightforward.