flake.nix: add macOS (Darwin) support #393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add platform detection for Darwin vs Linux - Handle different libdfuprog paths and extensions (.so/.dylib) - Use appropriate library path env var (LD_LIBRARY_PATH/DYLD_LIBRARY_PATH) - Handle binary name differences (labrador/Labrador) - Install icons and desktop files only on Linux - Use sysctl fallback for CPU count on macOS - Update platforms to include darwin
Collaborator
|
If it's not possible to test on macOS, I think we just keep support limited to Linux. |
Contributor
Author
|
Makes sense. If we do find somebody with Darwin, then it would be great to test it! |
Contributor
While this is "developer speak" I believe it means any macOS or iOS version should work for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
G'day Chris,
I just created the nixpkgs pull request, so it will be easy for people to see Labrador is supported by Nixpkgs. Once merged it will also sort of make the Flake redundant.
NixOS/nixpkgs#477199
However, I noticed that I would also improve the platform support adding Darwin to the flake.
I don't have a recent Apples devices, so this is untested.
Thanks,
Dave