Skip to content

Conversation

@brentfpage
Copy link
Contributor

Added new trigger type options, Sig. Gen. Ch1 and Ch2 , that set the trigger frequency equal to the respective sig. gen. frequencies. In these modes, there's no need to adjust the trigger level to get the waveform steady on the screen. The feature gets finicky above ~25 khz or so, especially when 'scope channel 2 is enabled. I've dug around trying to find a cause, but haven't had any luck yet. The issue only appears in a limited operating range (>~ 25 khz), is not all that common even in that range, and can usually be resolved by disabling/enabling 'scope channel 2, so imo isn't a huge demerit for the PR. Also, #288 is fixed in this PR.

@EspoTek
Copy link
Collaborator

EspoTek commented Jan 4, 2026

Just for what it's worth, the signal gen runs from a 1MSPS DAC, and at higher frequencies the waveform reduces in resolution to compensate.

At higher frequencies I'd expect quantisation noise by itself to get to something like 5% of the period of a waveform.

@brentfpage
Copy link
Contributor Author

brentfpage commented Jan 7, 2026

I think I correctly handled

at higher frequencies the waveform reduces in resolution to compensate

but I should double check.

At higher frequencies I'd expect quantisation noise by itself to get to something like 5% of the period of a waveform.

Can you please elaborate? Say a single period of the waveform gets produced over the course of 2^10 clock cycles and a single 'scope sample is collected every 2^3 clock cycles. If you then add a trigger point every 2^7 'scope samples, shouldn't that keep the waveform steady on the screen?

@mi-hol
Copy link
Contributor

mi-hol commented Jan 15, 2026

but I should double check.

@brentfpage are we ready to merge?

@brentfpage
Copy link
Contributor Author

are we ready to merge?

@mi-hol I'd prefer to spend a bit more time trying to improve the performance at >25 khz

@mi-hol mi-hol marked this pull request as draft January 19, 2026 18:30
@mi-hol
Copy link
Contributor

mi-hol commented Jan 19, 2026

I'd prefer to spend a bit more time trying to improve the performance at >25 khz

@brentfpage that is at best signaled to others via setting the PR to "draft" status by clicking on "convert to draft" link.

image

I've applied that for you. As soon as it's ready from your view just remove "draft" status by pressing
"Ready for review" button
image

@brentfpage
Copy link
Contributor Author

@mi-hol Ah OK thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants