Improve performance of "P1Parser::parse" by using std::map. Various refactoring.#38
Merged
PolarGoose merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
PolarGoose
changed the title
PolarGoose
force-pushed
the
use_map_in_ParsedData_parse_line_function
branch
7 times, most recently
from
dc7a60d to
7303dfb
Compare
…_map in `ParsedData::parse_line` instead of iterating over all fields to parse each field from a DSMR telegram. * Small refactoring. Accept `ParsedData` by reference instead of by pointer. * Add reference document "IEC.62056-61-2006 - Object identification system (OBIS).pdf" * Move `src/test` to `tests` folder because it is a more idiomatic folder structure for a C++ library. * Add `noexcept` where applicable
PolarGoose
force-pushed
the
use_map_in_ParsedData_parse_line_function
branch
from
7303dfb to
eb70dd1
Compare
PolarGoose
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P1Parser::parsemethod. Use std::map inParsedData::parse_lineinstead of iterating over all fields to parse each field from a DSMR telegram.ParsedDataby reference instead of by pointer.src/testtotestsfolder because it is a more idiomatic folder structure for a C++ library.noexceptwhere applicable