Skip to content

Fix CPU sets reconcile for in place vertical scaling with exclusive CPUs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaszwojciechowski wants to merge 15 commits into
base: policy_static
Choose a base branch
from
Open

Fix CPU sets reconcile for in place vertical scaling with exclusive CPUs #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
db9443b
Static CPU management policy alongside InPlacePodVerticalScaling
esotsal Jan 20, 2025
5ab81b1
Support InPlacePodVerticalScaling for Static CPU management policy
Chunxia202410 Feb 21, 2025
29452ba
Fix go fmt isssues
esotsal Feb 21, 2025
9b0a7aa
Fix mutation heuristic check of mustKeepCPUs, reason is clone
esotsal Feb 22, 2025
5d4e9ee
Fix glangci-lint-pr failed test
esotsal Mar 3, 2025
6d524a1
Fix compile issue, due to update in e2e/framework removing rollback bool
esotsal Mar 12, 2025
529a7c4
Fix compile issue and address review comment.
esotsal Mar 17, 2025
7879ca3
Address sig-node meeting comments for mustKeepCPUs.
esotsal Mar 28, 2025
37cd3f3
Refactor using lifecycle.Operation
esotsal Mar 3, 2026
7111a54
Separate flow, put back of FG, infeasible resize on TopologyAffinityE…
esotsal Mar 6, 2026
a5fd8a5
kubelet: enhance TestReconcileState
lukaszwojciechowski Feb 11, 2026
9207247
kubelet: verify CPUSets set in mock runtime
lukaszwojciechowski Mar 6, 2026
768d48d
kubelet: add resize testcases for reconcileState
lukaszwojciechowski Feb 11, 2026
31e893b
kubelet: rework CPUSet reconciliation algorithm
lukaszwojciechowski Mar 6, 2026
4b31238
kubelet: test cpu-manager multi-pass reconcilation
lukaszwojciechowski Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/kubelet/allocation/allocation_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import (
v1qos "k8s.io/kubernetes/pkg/apis/core/v1/helper/qos"
"k8s.io/kubernetes/pkg/features"
"k8s.io/kubernetes/pkg/kubelet/allocation/state"
"k8s.io/kubernetes/pkg/kubelet/cm/topologymanager"
"k8s.io/kubernetes/pkg/kubelet/config"
kubecontainer "k8s.io/kubernetes/pkg/kubelet/container"
"k8s.io/kubernetes/pkg/kubelet/events"
Expand Down Expand Up @@ -592,6 +593,11 @@ func (m *manager) handlePodResourcesResize(logger klog.Logger, pod *v1.Pod) (boo
}

if reason != "" {
if utilfeature.DefaultFeatureGate.Enabled(features.InPlacePodVerticalScalingExclusiveCPUs) {
if reason == topologymanager.ErrorTopologyAffinity {
reason = v1.PodReasonInfeasible
}
}
if m.statusManager.SetPodResizePendingCondition(pod.UID, reason, message, pod.Generation) {
eventType := events.ResizeDeferred
if reason == v1.PodReasonInfeasible {
Expand Down
720 changes: 720 additions & 0 deletions pkg/kubelet/cm/cpumanager/cpu_assignment.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading